Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add arm64 windows build to node-v8 repo #35721

Closed
wants to merge 1 commit into from
Closed

build: add arm64 windows build to node-v8 repo #35721

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Fix: #35677

Why we need such a thing ?

V8 doesn't have an arm64 CI on windows, make it very hard to find issues on windows arm64. Like V8 8.6, fixing arm issue take quite some time since we don't know which commit start failing.
node-v8 sync v8 daily, so it will be easy for us notice arm64 failure and debug.

Why not enable this on main repo,

Jenkins already has arm64 setup and running on windows. And cross compile is drastically slow on windows (near 2x slow IIRC).

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 20, 2020
@gengjiawen
Copy link
Member Author

cc @richard-townsend-arm @nodejs/platform-arm

@gengjiawen gengjiawen changed the base branch from canary-base to master October 20, 2020 15:19
@targos
Copy link
Member

targos commented Oct 20, 2020

@gengjiawen Every time canary is updated, the Node.js CI is run. There is a separate job for it so it's easy to check and it includes the windows on ARM build: https://ci.nodejs.org/view/MyJobs/job/node-test-commit-node-v8/

@gengjiawen
Copy link
Member Author

gengjiawen commented Oct 20, 2020 •
edited
Loading

@gengjiawen Every time canary is updated, the Node.js CI is run. There is a separate job for it so it's easy to check and it includes the windows on ARM build: ci.nodejs.org/view/MyJobs/job/node-test-commit-node-v8

Thear are some flaws if we use jenkins:

  • one thing is that jenkins will delete logs. Github action will keep log. This will be useful when investigate build issues.
  • it's very easy on linear build history check.

@gengjiawen gengjiawen added v8 engine Issues and PRs related to the V8 dependency. arm Issues and PRs related to the ARM platform. labels Oct 21, 2020
@targos
Copy link
Member

targos commented Oct 21, 2020

Ok, thanks. I just pushed it to canary-base (without the condition). It seems easier to float it there instead of maintaining it on the main branch.

@targos targos closed this Oct 21, 2020
@gengjiawen gengjiawen mentioned this pull request Oct 21, 2020
Closed
@gengjiawen gengjiawen deleted the arm64 branch October 21, 2020 09:01
@gengjiawen
Copy link
Member Author

Ok, thanks. I just pushed it to canary-base (without the condition). It seems easier to float it there instead of maintaining it on the main branch.

I prefer in the master (keep floating patch less). But both fine with me.

@targos
Copy link
Member

targos commented Oct 21, 2020

Ideally, it would be in the main branch of the node-v8 repo. Related: nodejs/node-v8#170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. meta Issues and PRs related to the general management of the project. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve arm64 workflow on windows
3 participants
@gengjiawen @targos @nodejs-github-bot